Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qr code to comment #98

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add Qr code to comment #98

wants to merge 15 commits into from

Conversation

lredoban
Copy link
Contributor

Screenshot 2025-01-10 at 13 34 15

@rossjrw rossjrw added the enhancement New feature or request label Jan 10, 2025
@rossjrw
Copy link
Owner

rossjrw commented Jan 10, 2025

Oh, this is a really good idea. I'm into this.

I changed how the comment looks in #97 which will add a bit more space for the image, but I'd still like to make it a bit smaller, plus maybe some sort of size optimisation based on how long the URL is (the example size you've given could probably be smaller for short URLs, maybe it's too small for really big URLs).

https://goqr.me/api/ seems to be the operating site for qrserver.com, and their ToS is nonexistent so I'm not comfortable including it in this project. But it could be worth finding an alternative or just generating it on the runner.

@lredoban
Copy link
Contributor Author

You're totally right for qrserver.com, I've made some changes to generate the QR code with https://github.com/unjs/uqr.
But as github comments don't handle base64 images I have to put it inside a code block.
I put all this inside a "details" tag so it doesn't take space.

Let me know if I need to make some changes

Screenshot 2025-01-13 at 15 31 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants