-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qr code to comment #98
base: main
Are you sure you want to change the base?
Conversation
lredoban
commented
Jan 10, 2025
Oh, this is a really good idea. I'm into this. I changed how the comment looks in #97 which will add a bit more space for the image, but I'd still like to make it a bit smaller, plus maybe some sort of size optimisation based on how long the URL is (the example size you've given could probably be smaller for short URLs, maybe it's too small for really big URLs). https://goqr.me/api/ seems to be the operating site for qrserver.com, and their ToS is nonexistent so I'm not comfortable including it in this project. But it could be worth finding an alternative or just generating it on the runner. |
You're totally right for qrserver.com, I've made some changes to generate the QR code with https://github.com/unjs/uqr. Let me know if I need to make some changes |