Use Prettier to Auto-Format the Code #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrann0us
reviewed
May 2, 2022
|
@GenieTim Thanks for this. Code standards are good! I appreciate the contribution. Please don't take my lack of reply as me not being interested. I've just not used Prettier before and want to figure out what this is doing before I merge it. |
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
|
This will be fixed by #18 which has had the main branch merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very opinionated PR; while it includes the changes from #14, its main contribution is the set-up and initial run of the opinionated code formatter Prettier. While this is an arbitrary choice — as is Prettier's default configuration — I would highly suggest you offer some configuration with a corresponding tool in order to have consistent PRs and reduce merge-conflicts from people with different auto-formatters in their IDE. This here would be my suggestion on how this could be.
One more little thing that it includes: in index.html, there seems to be an unclosed
<div>and in turn a closing</article>without the corresponding opening tag — this would be fixed with this PR, too.Thanks anyway!