Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Automated foclassic.h generation #10

Open
1 of 3 tasks
wipe2238 opened this issue Sep 23, 2018 · 0 comments
Open
1 of 3 tasks

Automated foclassic.h generation #10

wipe2238 opened this issue Sep 23, 2018 · 0 comments
Labels
internal Here be dragons

Comments

@wipe2238
Copy link
Member

wipe2238 commented Sep 23, 2018

In SDK, fonline.h was always edited manually; in fact, it never was part of source repo at all. It's a working solution, sure, but i'd like to automate it, to minimize possible human mistakes resulting in broken dlls.

In perfect world, we'd just copy related headers (Critter.h, Item.h, Map.h, and so on), write a wrapper with #include wall, add entry point stuff etc. and be done with it.

That, however, won't work as headers aren't written with such exposure in mind. Just look at Common.h which is must-have with such approach - wall of #pragma comment(lib) and #include for almost all third party libs, and that's just a beginning. Ugh.

I don't consider it as a part of any currently planned milestones. V15 will most likely affect it, but automated dll header creation should be a result of various changes, rather than a goal. As of now, i've included header in repo, so we can at least connect changes in header with changes in engine, by simply doing both in one commit.

Things which we can prepared beforehand:

  • add dummy dll target into build process; if it fails on exactly same compiler, it's a major screwup
  • make a proper test and include at least one other toolset
  • use external tools for testing across multiple compilers (appveyor, travis)

I'll probably get on that at some point in future, as of today it's very minor priority.

@wipe2238 wipe2238 added the internal Here be dragons label Sep 23, 2018
wipe2238 added a commit that referenced this issue Nov 1, 2018
- .bat/.cmd needs crlf instead of lf
- sizeof base types dump (previously commented) moved to MainServer for quick check
- added sizeof(string) to base types checks
- removed stlport leftovers from mapper
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
internal Here be dragons
Projects
None yet
Development

No branches or pull requests

1 participant