Corrected CMS copy profiles, was hardcoded for 3 profiles only. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersHoglund
changed the title
rotorflight
requested changes
Jun 27, 2024
src/main/cms/cms_menu_imu.c
Outdated
| "-", | ||
| "1", | ||
| "2", | ||
| "3" | ||
| #if PROFILE_COUNT >= 4 | ||
| ,"4" |
There was a problem hiding this comment.
I suggest using "...", (comma in the end for all entries)
as it is more readable. C allows the comma after the last entry, so that's not a problem.
There was a problem hiding this comment.
No need to figure out the max number of profiles... you could simply define the names for 6, as thats the maximum
AndersHoglund
force-pushed
the
fix_cms_profile_copy_count
branch
from
7debef3
to
3b2b242
Compare
|
OK, updated according to comment. |
rotorflight
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMS copy profiles was hard coded for 3 profiles only. Now follows config item PROFILE_COUNT, up to max 6 profiles.