-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix R example and run examples in CI #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. looks good.
The PR looks OK, but there's still a failing test on the Julia side. |
I can’t figure out the Julia test failure. My current guess is it’s an issue with Julia 1.9.0 which was released yesterday |
I've got to move on to other things for now, but here's a quick update on my progress so far. Julia 1.8 and 1.9 output different error messages when tested against the same faulty Stan programs.
Julia 1.8: ERROR: construct(, 204) failed with exception: Exception: find this text: datafails Julia 1.9: ERROR: construct(, 204) failed with unknown exception
Julia 1.8: ERROR: log_density() failed with exception: Exception: find this text: lpfails Julia 1.9: ERROR: log_density() failed with unknown exception What seems odd to me is the differences between these error messages comes from the C++ file The quickest/hackiest fix would be to change line 9 in the file |
I've also spent some time running it down and just filed an issue with Julia: JuliaLang/julia#49772. |
This closes #121 by removing the extra argument (left over from pre- #98) and also adds a line to run each example program as part of our CI to make sure they stay up-to-date.