Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/226 julia manual download #227

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Conversation

WardBrian
Copy link
Collaborator

This closes #226 and brings the Julia interface in line with the others by storing the bridgestan sources in ~/.bridgestan

A couple things worth noting:

  • Julia's expanduser function does nothing on Windows. I've added a helper function to get the home directory based on what Python does
  • This adds a few "dependencies": Tar, TOML, Downloads, and Inflate. I use the scare quotes because all except for Inflate are built in to Julia. Inflate, meanwhile, is used in examples in Julia's documentation, and seems very stable.

@WardBrian WardBrian force-pushed the fix/226-julia-manual-download branch from d366690 to d2900c1 Compare April 15, 2024 15:54
@WardBrian
Copy link
Collaborator Author

Ok, so Julia's Tar library didn't support hardlinks until Julia 1.7: JuliaIO/Tar.jl#102

I've updated the release action to generate tarballs without them (it's just a single extra copy of bridgestan.h), but in the mean time the Julia 1.6 test will stay failing. Not really sure what to do

@WardBrian
Copy link
Collaborator Author

I confirmed that adding --hard-dereference to our packaging step produces a tarball which julia 1.6 can read.

So, we can either:

  • merge this while it is failing, knowing the next release will actually be fine
  • merge just the release.yml change to add that flag, make a small release, and then merge the Julia changes

Copy link
Owner

@roualdes roualdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. And thanks for finding a fix that includes Julia 1.6. Since 1.6 is the LTS version, it seems right to include it.

I guess it's better to get this fix out there, and then tidy 1.6 issues later, since this PR started based on a reported issue with Julia 1.10, and not an issue related to 1.6. Maybe that's wrong, but that's my thought.

@WardBrian WardBrian merged commit 6f8a516 into main Apr 17, 2024
18 of 19 checks passed
@WardBrian WardBrian deleted the fix/226-julia-manual-download branch April 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving Julia download away from LazyArtifacts
2 participants