Send Stan outputs to stdout rather than stderr #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roualdes
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
So these changes are only for Stan print statements, ya? Which is why the error messages in bridgestan.cpp are left unchanged, right?
And printing to cout still depends on Stan flushing (re stan-dev/stanc3#1301)? Since that PR has already been approved, this PR is just moving a touch faster? Which I'm ok with; just trying to make sure that a second set of eyes crosses t's and dots i's.
|
Correct, this only affects Stan print statements. I just merged the stanc3 PR to flush the output, but even without that this is still better than the current state of things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #93.
Currently, all Stan print statements were redirected to stderr, this changes to stdout while we explore other options.