[GUI] Use QgsFields::isFieldReadOnly()

rouault · May 25, 2024 · babceb6 · babceb6
1 parent bbb42a4
commit babceb6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/src/core/editform/qgseditformconfig.cpp b/src/core/editform/qgseditformconfig.cpp
@@ -235,10 +235,7 @@ bool QgsEditFormConfig::readOnly( int idx ) const
 {
   if ( idx >= 0 && idx < d->mFields.count() )
   {
-    if ( d->mFields.fieldOrigin( idx ) == QgsFields::OriginJoin
-         || d->mFields.fieldOrigin( idx ) == QgsFields::OriginExpression )
-      return true;
-    if ( d->mFields.at( idx ).isReadOnly() )
+    if ( d->mFields.isFieldReadOnly( idx ) )
       return true;
     return !d->mFieldEditables.value( d->mFields.at( idx ).name(), true );
   }

diff --git a/src/gui/attributeformconfig/qgsattributetypedialog.cpp b/src/gui/attributeformconfig/qgsattributetypedialog.cpp
@@ -61,9 +61,7 @@ QgsAttributeTypeDialog::QgsAttributeTypeDialog( QgsVectorLayer *vl, int fieldIdx
 
   connect( mWidgetTypeComboBox, static_cast< void ( QComboBox::* )( int )>( &QComboBox::currentIndexChanged ), this, &QgsAttributeTypeDialog::onCurrentWidgetChanged );
 
-  if ( vl->fields().fieldOrigin( fieldIdx ) == QgsFields::OriginJoin ||
-       vl->fields().fieldOrigin( fieldIdx ) == QgsFields::OriginExpression ||
-       vl->fields().field( fieldIdx ).isReadOnly() )
+  if ( vl->fields().isFieldReadOnly( fieldIdx ) )
   {
     isFieldEditableCheckBox->setEnabled( false );
   }

diff --git a/src/gui/vector/qgsattributesformproperties.cpp b/src/gui/vector/qgsattributesformproperties.cpp
@@ -1082,9 +1082,7 @@ QgsAttributesFormProperties::FieldConfig::FieldConfig( QgsVectorLayer *layer, in
   mDataDefinedProperties = layer->editFormConfig().dataDefinedFieldProperties( layer->fields().at( idx ).name() );
   mComment = layer->fields().at( idx ).comment();
   mEditable = !layer->editFormConfig().readOnly( idx );
-  mEditableEnabled = layer->fields().fieldOrigin( idx ) != QgsFields::OriginJoin
-                     && layer->fields().fieldOrigin( idx ) != QgsFields::OriginExpression
-                     && !layer->fields().at( idx ).isReadOnly();
+  mEditableEnabled = !layer->fields().isFieldReadOnly( idx );
   mLabelOnTop = layer->editFormConfig().labelOnTop( idx );
   mReuseLastValues = layer->editFormConfig().reuseLastValue( idx );
   mFieldConstraints = layer->fields().at( idx ).constraints();