Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent use of template tag highlighting #1237

Closed
pyrmont opened this issue Jun 30, 2019 · 3 comments
Closed

Fix inconsistent use of template tag highlighting #1237

pyrmont opened this issue Jun 30, 2019 · 3 comments
Labels
bugfix-request A request for a bugfix to be developed. stale-issue There has been no activity for a year.

Comments

@pyrmont
Copy link
Contributor

pyrmont commented Jun 30, 2019

Name of the lexer
Handlebars, JSP, Smarty (possibly others).

Online example
N/A

Code sample
N/A

Additional context
The above-mentioned lexers are template lexers that do not use Comment::Preproc as the token for their template tags. This was identified by @miparnisari in this comment.

@pyrmont pyrmont added the bugfix-request A request for a bugfix to be developed. label Jun 30, 2019
@miparnisari
Copy link
Contributor

Note that Comment::Preproc prints text in italics which might be undesirable. E.g. if you try to highlight <&| it will look like <&/

@pyrmont
Copy link
Contributor Author

pyrmont commented Jul 1, 2019

As noted in the discussion in the PR, the token doesn't impact the way the text appears, that's the stylesheet. Any token will have the problem you're describing if the CSS rule for that token causes it to display with italics.

@stale
Copy link

stale bot commented Jun 30, 2020

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Jun 30, 2020
@stale stale bot closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix-request A request for a bugfix to be developed. stale-issue There has been no activity for a year.
Projects
None yet
Development

No branches or pull requests

2 participants