Remove italics from preprocessor style rules #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three of the default themes that come with Rouge italicise text tokenised with the
Comment::Preproc
token. This is consistent with the styling applied to other tokens within theComment
group but is not appropriate for a token that is typically used with code that can include characters like/
(theComment::Preproc
token is the recommended token for PHP and ERB, for example).This commit removes the italics attribute from the themes Magritte, Thankful Eyes and Tulip. The styles are otherwise left unchanged. It is expected that this change will precede a separate PR that will address #1237.