Remove italics from preprocessor style rules #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three of the default themes that come with Rouge italicise text tokenised with the `Comment::Preproc` token. This is consistent with the styling applied to other tokens within the `Comment` group but is not appropriate for a token that is typically used with code that can include characters like `/` (the `Comment::Preproc` token is the recommended token for PHP and ERB, for example). This commit removes the italics attribute from the themes Magritte, Thankful Eyes and Tulip. The styles are otherwise left unchanged.
Merged
@pyrmont I think you meant to reference the pipe char ( Also, is there a community standard where the styles for each token in a given theme are defined or are they arbitrarily decided when authoring the theme? |
miparnisari
approved these changes
Jul 16, 2019
|
@ashmaroli Thank you, yes I meant characters like As for the token styles, I believe they're arbitrarily decided by the author. In that sense, the decision as to whether to use italics or not is a stylistic one for which it could be argued there is no 'wrong' answer. I find that argument persuasive generally but, at least in the case of the Thankful Eyes theme, I think having styles that don't generate ambiguity should be preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three of the default themes that come with Rouge italicise text tokenised with the
Comment::Preproctoken. This is consistent with the styling applied to other tokens within theCommentgroup but is not appropriate for a token that is typically used with code that can include characters like/(theComment::Preproctoken is the recommended token for PHP and ERB, for example).This commit removes the italics attribute from the themes Magritte, Thankful Eyes and Tulip. The styles are otherwise left unchanged. It is expected that this change will precede a separate PR that will address #1237.