Recognize more Julia types and constants #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to interpret the test failures. |
ararslan
force-pushed
the
aa/better-julia
branch
from
303bbad
to
3e085fa
Compare
Summary of changes: * Expand the list of recognized types to all types exported from Julia's Base and Core modules, as well as all of its standard library packages. A Julia script for generating the list is included as a comment. * Add a missing keyword. * Add a few constants missing from the builtins list. * Highlight macro names in the same manner as function names in definitions. * Minor, incomplete corrections and improvements to the visual Julia sample. * Inline TODOs to remind onlookers of currently missing functionality for Julia highlighting. * Add a missing operator. * Fix highlighting of macro calls.
ararslan
force-pushed
the
aa/better-julia
branch
from
3e085fa
to
30fa037
Compare
|
I've reverted my changes to the visual sample, which seems to have fixed the tests. |
|
Bump @dblessing |
1 similar comment
|
Bump @dblessing |
|
Thanks for adding these, @ararslan. Sorry it took a while to get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of #934.
Summary of changes:
Expand the list of recognized types to all types exported from Julia's Base and Core modules, as well as all of its standard library packages. A Julia script for generating the list is included as a comment.
Add a missing keyword.
Add a few constants missing from the builtins list.
Highlight macro names in the same manner as function names in definitions.
Minor, incomplete corrections and improvements to the visual Julia sample.Inline TODOs to remind onlookers of currently missing functionality for Julia highlighting.
Add a missing operator.
Fix highlighting of macro calls.