Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for (Smallworld) Magik language #1044

Merged
merged 6 commits into from
Jun 12, 2019
Merged

Support for (Smallworld) Magik language #1044

merged 6 commits into from
Jun 12, 2019

Conversation

StevenLooman
Copy link
Contributor

This adds support for the (Smallworld) Magik language. It is a language specific to a GIS (Geo) software package.

Please do not merge yet, the regexp for identifier is not behaving yet. I.e., on longer identifiers it seems to be exploding with regard to time it needs to match.

@StevenLooman StevenLooman changed the title WIP: Support for (Smallworld) Magik language Support for (Smallworld) Magik language Dec 1, 2018
@StevenLooman
Copy link
Contributor Author

Fixed the identifier, no longer giving problems and works for all my test cases.

Can be merged in my opinion, please review.

@StevenLooman
Copy link
Contributor Author

@dblessing @jneen What should I do to get this merged? Any review is welcome.

@vidarh vidarh mentioned this pull request Jan 13, 2019
Closed
@pyrmont pyrmont mentioned this pull request May 12, 2019
Merged
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label May 28, 2019
pyrmont
pyrmont suggested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's taken so long to get this reviewed. Let me know if you have any questions!

lib/rouge/demos/magik Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/magik.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jun 12, 2019
@StevenLooman
Copy link
Contributor Author

Thank you for picking this up, great to see this project is still alive!

I've handled most of the requests, but I'm unsure on how to fix the error. Please advise.

@pyrmont
Copy link
Contributor

pyrmont commented Jun 12, 2019

@StevenLooman Looks like you found the mistake. The tests should pass now; am looking over the other changes :)

@pyrmont pyrmont merged commit ea99dc4 into rouge-ruby:master Jun 12, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jun 12, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 12, 2019

Thanks for submitting a new lexer, @StevenLooman! This helps make Rouge a better library :)

We're looking at a two-week cadence for updates to the gem as we work through the backlog of outstanding PRs so this should land in 3.5.0 in about two weeks (3.4.0 came out on Wednesday).

@StevenLooman StevenLooman deleted the magik-language branch June 13, 2019 07:11
@StevenLooman
Copy link
Contributor Author

Thank you for merging @pyrmont! Looking forward to a release, and hopefully landing in Gitlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenLooman @pyrmont