Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin suspend keyword #1055

Merged
merged 1 commit into from
May 29, 2019
Merged

Kotlin suspend keyword #1055

merged 1 commit into from
May 29, 2019

Conversation

Pitel
Copy link
Contributor

@Pitel Pitel commented Jan 4, 2019

Since Kotlin coroutines are no longer experimental, suspend should be a highlighted keyword.

It seems GitHub has it:

private suspend fun foo() = 42

Disclaimer: I don't know Ruby, I didn't tested it, I just want to have proper syntax highligting in GitLab, which uses this syntax highlighting library. So feel free to fix it, or tell me how to implement it properly.

@pyrmont
Copy link
Contributor

pyrmont commented May 28, 2019

@Pitel Sorry for the delay in getting back to you on this. Could you do a force push to kick off CI testing with the updated files?

Something like

$ git commit --amend
$ git push --force

should do the trick.

@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label May 28, 2019
(force push)
@Pitel
Copy link
Contributor Author

Pitel commented May 29, 2019

Done.

@pyrmont pyrmont merged commit fa1ef1c into rouge-ruby:master May 29, 2019
@pyrmont
Copy link
Contributor

pyrmont commented May 29, 2019

Thanks @Pitel! :)

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants