Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce state names into symbols instead of strings #1138

Merged
merged 1 commit into from
May 31, 2019
Merged

Coerce state names into symbols instead of strings #1138

merged 1 commit into from
May 31, 2019

Conversation

ashmaroli
Copy link
Contributor

Based on #1135 (comment) and #1135 (comment)

Summary

If state name is already a Symbol, use that directly. Otherwise, convert the String name into a Symbol

Gotcha

Unhandled exception if state name doesn't respond to :to_sym

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label May 31, 2019
@pyrmont pyrmont merged commit c1e1388 into rouge-ruby:master May 31, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label May 31, 2019
@ashmaroli ashmaroli deleted the coerce-names-to-symbols branch June 2, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashmaroli @pyrmont