Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align style parameters in magritte theme #1185

Merged
merged 1 commit into from
Jun 17, 2019
Merged

align style parameters in magritte theme #1185

merged 1 commit into from
Jun 17, 2019

Conversation

ashmaroli
Copy link
Contributor

@jneen This is to align the style parameters of the proposed Magritte theme in #1182 in sync with existing themes

@jneen
Copy link
Member

jneen commented Jun 14, 2019

I've updated the original PR. Thanks though!

@jneen jneen closed this Jun 14, 2019
@ashmaroli
Copy link
Contributor Author

@jneen I know that you have updated the PR since my comment.
But the changes proposed here are for the parameters of :style instead of palette...

@ashmaroli
Copy link
Contributor Author

@pyrmont Could you reopen this PR? @jneen closed it due to a misunderstanding.

@pyrmont pyrmont reopened this Jun 17, 2019
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 17, 2019
@pyrmont pyrmont merged commit 3b2f1e8 into rouge-ruby:feature.magritte-theme Jun 17, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 17, 2019
@ashmaroli ashmaroli deleted the feature.magritte-theme branch June 17, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmaroli @jneen @pyrmont