Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lexer for MessageTrans messages files #1283

Merged
merged 9 commits into from
Jul 31, 2019

Conversation

bavison
Copy link
Contributor

@bavison bavison commented Jul 26, 2019

These are commonly used for key-value string lookup (with basic parameter
substitution facilities) on RISC OS. Typically, each application will be
distributed with one such file for each locale that it has been translated
into.

These are commonly used for key-value string lookup (with basic parameter
substitution facilities) on RISC OS. Typically, each application will be
distributed with one such file for each locale that it has been translated
into.
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 26, 2019
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bavison Man, you're on a roll. Thanks for submitting another PR! Here's some comments:

lib/rouge/lexers/msgtrans.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/msgtrans.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/msgtrans.rb Show resolved Hide resolved
lib/rouge/lexers/msgtrans.rb Outdated Show resolved Hide resolved
spec/visual/samples/msgtrans Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jul 28, 2019
@pyrmont pyrmont merged commit 0060928 into rouge-ruby:master Jul 31, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 31, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 31, 2019

Thanks again, @bavison, for submitting another lexer! I realise the filename situation isn't ideal but hopefully this is still useful for your use-case >_<

bavison added a commit to bavison/rouge that referenced this pull request Sep 9, 2019
This commit adds a lexer for MessageTrans, a module for RISC OS which
provides facilities for looking up text in a file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants