Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty reason responses in HTTP lexer #1313

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Aug 26, 2019

The HTTP 1.1 spec permits empty reason-phrase elements in HTTP responses. The HTTP lexer requires a reason-phrase to be given. This commit corrects that.

This fixes #977.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Aug 26, 2019
@pyrmont pyrmont self-assigned this Aug 26, 2019
@pyrmont pyrmont merged commit fdbf747 into rouge-ruby:master Aug 30, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Aug 30, 2019
@pyrmont pyrmont deleted the bugfix.http-empty-reason-phrase branch January 8, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP lexer : allow empty Reason Phrase in HTTP Response
1 participant