-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Idris language #1464
Conversation
hey @pyrmont, could you take a look? |
@bmwant Sorry not to have got around to this yet. I'm afraid I haven't had much time to spend on Rouge of late but will try to remedy that soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Have a couple of comments:
👋🏼 @bmwant we would love to hear back from you. Is there anything we can help to push this PR forward? |
@tancnle hey, I can recall that I've faced a couple of blocking issues when trying to address these simple at a first glance comments. I cannot remember whether it was related to the Ruby language (as I'm not a Ruby developer per se) or to the implementation details of the lexer itself (regex lexers are trickier to implement). |
@bmwant Thank you for getting back to me. I am happy to lend a hand with the latter. Idris is an interesting language and this addition to Rouge will definitely improve the exp. for our developers. I will review those comments from |
Would it be possible to add a simpler version of Idris highlighting first, and then polish it later? I've been using Haskell highlighting for my Idris code blocks, and that looks terrible, so for me any real Idris support at all would be an improvement. (I'm afraid I don't have anything concrete to offer in terms of this PR. This is just a suggestion to take the simpler-sooner route.) |
@bmwant In the spirit of iteration, I will merge this change 👍🏼. Please let me know if you have any concerns and/or raise another PR to address them. Again, thank a lot for your hard work on this PR 🙇🏼 |
Description
Testing