Simplify default rule in YANG lexer #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
added
the
author-action
|
@gribok Can you add an example to the visual sample so that we can see the rule working there? |
The example would break the compiler check, if someone would copy&paste it. |
|
@gribok Thanks for the PR. Got it merged in now 🎉 |
pyrmont
removed
the
author-action
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
Although strings of the form `+abc*iu` should be tokenised as correct by the Yang lexer, they currently produce errors. This commit fixes this problem by reducing the characters excluded by the default rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify rule to reduce complexity.
Example:
Strings like
+abc*iushould be valid names for syntax highlighting.In old version
+and*would be an invalid token and marked as red.Correct validation will be done through compiler.