-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fat comma in Perl lexer #1553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miparnisari How does this look to you? |
pyrmont
force-pushed
the
bugfix.perl-fat-comma
branch
from
July 5, 2020 05:17
2a6f038
to
d84ba5f
Compare
@jneen This PR now correctly lexes the following:
It does this using a regular expression similar to the one you suggested: rule(/(?=[a-z_]\w*(\s*#.*)*\s*=>)/i) { push :fat_comma } This looks good to me but if you can think of any issues, let me know. |
@jneen I realised that the previous rule would match comments that contained a fat arrow. This variation fixes that: rule(/(?=[a-z_]\w*(\s*#.*\n)*\s*=>)/i) { push :fat_comma } |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The `=>` operator (sometimes called the 'fat comma') is an operator in Perl that causes the identifier to the immediate left of the fat comma to be treated as if it were a string. This commit adds support for it using a simple lookahead heuristic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
=>
operator (sometimes called the 'fat comma') is an operator in Perl that causes the identifier to the immediate left of the fat comma to be treated as if it were a string. See additional explanation in the answers to this StackOverflow question.This fixes #1164.