Support template parameter packs in C++ lexer #1555
Conversation
|
@szilardszaloki I think this fixes the problem. Let me know what you think! |
|
@pyrmont Thanks for the fix! Unfortunately, I'm not at all familiar with ruby, just using rouge via GitHub Pages. How about me checking it with recompiling my page when it goes live? Anyhow, the C++ lexer didn't have this issue a couple of weeks ago, so if the fix produces the same output as it did back then, then I guess we're good to go. :) |
|
@szilardszaloki Yeah, unfortunately there's not a simple way to test the code in a PR. You'd basically need to pull it down onto your system and use it to highlight some text. If you're using Rouge via GitHub Pages, you're really using Jekyll and you can set up a local instance, then specify this fork in your GemFile... not exactly simple. I'm pretty sure it's working properly now. It's at least correctly highlighting the code that you indicated in the original issue was problematic. I'll merge this in and it'll be part of v3.21.0 of Rouge. That will be released on Tuesday 14 July and should start being used relatively soon in GitHub Pages (you can see the versions of the gems they're using here). |
|
Thanks, Michael! |
The change in rouge-ruby#1495 to the way that the `template` keyword caused template parameter packs not to be highlighted correctly. This commit fixes that bug while also introducing a more robust set of rules for highlighting identifiers succeeding the `template` keyword.
Template parameters are more complicated than you could possibly imagine. This adds support for template parameter packs.
It fixes #1546.