Fix identifier matching in Rego lexer #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcmcken I think this should provide a more robust set of rules. Oh, and as noted above, I also changed the token that's used to highlight rule names. I don't think using What do you think? |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The Rego lexer matches certain identifiers using `\b`. This will match identifiers that include `_`. This commit replaces these rules with a more robust generic regular expression. In addition, it changes the token used for variable names to `Name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rego lexer matches certain identifiers using
\b. This will match identifiers that include_. This PR replaces these rules with a more robust generic regular expression. In addition, it changes the token used for variable names toName.It fixes #1547.