Support quoting structs/tables in Janet lexer #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneen
approved these changes
Sep 25, 2020
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
This commit makes a number of fixes to the Janet lexer. Specifically, it: - supports quoting structs/tables; - fixes quoting of arrays and tables; and - removes unnecessary backslashes in character classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two errors in the Janet lexer:
The rule in
:rootfor closing parentheses, brackets and braces would cause an error if the symbol was unmatched as it would try topop()from the bottom-most state. To fix this, the rule in:rootshould notpop()at all. Rather, there should be rules in the other states.Quoting and quasi-quoting works with structs (marked by
{). This adds support for that.