Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dafny: New lexer for Dafny #1647

Merged
merged 12 commits into from
Sep 21, 2021
Merged

Dafny: New lexer for Dafny #1647

merged 12 commits into from
Sep 21, 2021

Conversation

davidcok
Copy link
Contributor

@davidcok davidcok commented Dec 9, 2020

This PR creates a rouge lexer for the Dafny programming language
(https://github.com/dafny-lang/dafny)

@mschlaipfer
Copy link
Contributor

Super excited for this!

@robin-aws
Copy link

Any concerns with this PR?

@tancnle
Copy link
Collaborator

tancnle commented Jul 15, 2021

Thanks for your contribution @davidcok 🙇🏼

I don't have any exp. with Dafny 😅 but will try my best to review this MR. After the first scan of the doc, I can verify that the sample looks good to me.

Screen Shot 2021-07-15 at 10 17 07 pm

There are no existing counterparts on https://github.com/pygments/pygments so it might be good to port it over at a later stage.

@tancnle
Copy link
Collaborator

tancnle commented Jul 15, 2021

@dblessing could you kindly do the maintainer review, please? 🙏🏼

spec/visual/samples/dafny Outdated Show resolved Hide resolved
spec/visual/samples/dafny Outdated Show resolved Hide resolved
@mschlaipfer
Copy link
Contributor

Hi, thanks for picking this up. Dafny has added some new keywords since this PR was opened. We would like to add them to this PR, if possible.

@davidcok
Copy link
Contributor Author

davidcok commented Jul 15, 2021 via email

@mschlaipfer
Copy link
Contributor

The new keywords are for and nameonly

@mschlaipfer
Copy link
Contributor

@davidcok I've created a PR against your feature.dafny branch. I haven't tested it. If that looks fine, I think by simply accepting my PR this PR will be updated.

@mschlaipfer
Copy link
Contributor

@tancnle we've addressed your comments and made the changes to bring this PR up to speed with recent changes to Dafny. From our side this PR can be merged. Thanks!

@tancnle
Copy link
Collaborator

tancnle commented Jul 23, 2021

@dblessing Could you please review and merge when you have some time, please? 🙏🏼

@robin-aws
Copy link

@tancnle @dblessing - We're so close! I can taste it! :) Any chance of reviewing and merging soon?

@tancnle
Copy link
Collaborator

tancnle commented Sep 19, 2021

@robin-aws Unfortunately, I do not have merge right on this repo. Sorry. 😢

@tancnle tancnle merged commit bcace45 into rouge-ruby:master Sep 21, 2021
@tancnle
Copy link
Collaborator

tancnle commented Sep 21, 2021

@mschlaipfer @davidcok @robin-aws Thank you for your patience and hard work on this one 🙇🏼 💯

@robin-aws
Copy link

And thank you @tancnle for the help! :)

What is the release cadence for rouge these days? I noticed the first .1 release went out a few days ago.

@dblessing
Copy link
Collaborator

@robin-aws As needed. We can do another release in the near future. I don't want people to have to wait long for merged changes.

@robin-aws
Copy link

Thanks @dblessing! Consider this a +1 for releasing soon then. The sooner we have a release the sooner I can pester downstream systems to pick it up so we really get the benefit! :)

@robin-aws robin-aws mentioned this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants