Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquid: update for 5.0.0 #1681

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Liquid: update for 5.0.0 #1681

merged 3 commits into from
Feb 19, 2023

Conversation

EricFromCanada
Copy link
Contributor

@EricFromCanada EricFromCanada commented Feb 18, 2021 •
edited
Loading

Now that Liquid 5.0.0 is out, this is a rework of the Liquid lexer for simplification and additional syntax features (including a few that aren't in the documentation yet):

@EricFromCanada EricFromCanada mentioned this pull request Feb 22, 2021
Merged
@tancnle tancnle assigned tancnle and unassigned tancnle Feb 14, 2023
@tancnle tancnle self-requested a review February 14, 2023 06:10
@tancnle tancnle added the needs-review The PR needs to be reviewed label Feb 14, 2023
@EricFromCanada
Copy link
Contributor Author

Happy 2nd birthday! Would love to see this in the next release.

@tancnle
Copy link
Collaborator

tancnle commented Feb 19, 2023

Thank you for your patience on this, @EricFromCanada 🙇🏼‍♂️. The change looks great to me. Let's ship it 🚀

@tancnle tancnle added this pull request to the merge queue Feb 19, 2023
Merged via the queue into rouge-ruby:master with commit 916ed4b Feb 19, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancnle tancnle Awaiting requested review from tancnle

Assignees
No one assigned
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricFromCanada @tancnle