Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Cypher multi-line comments #1710

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Support Cypher multi-line comments #1710

merged 3 commits into from
Jan 23, 2022

Conversation

ggrossetie
Copy link
Contributor

@ggrossetie ggrossetie commented Jun 7, 2021 •
edited
Loading

For reference, here's the Cypher EBNF related to comments:

Comment = ('/*', { ANY - ('*') | ('*', ANY - ('/')) }, '*/')
        | ('//', { ANY - (LF | CR) }, [CR], (LF | EOI))
        ;

resolves #1709

tancnle
tancnle reviewed Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Mogztter 👍🏼 The PR looks good to me. I have left some minor suggestions for your consideration. Please let me know what you think 🙏🏼

spec/visual/samples/cypher Outdated Show resolved Hide resolved
spec/support/lexing.rb Show resolved Hide resolved
spec/lexers/cypher_spec.rb Outdated Show resolved Hide resolved
@tancnle tancnle added the author-action The PR has been reviewed but action by the author is needed label Jan 18, 2022
@ggrossetie
Copy link
Contributor Author

Thanks for your review, I will update the PR accordingly in the next few days 😉

@ggrossetie
Copy link
Contributor Author

@tancnle should be OK now

@tancnle
Copy link
Collaborator

tancnle commented Jan 23, 2022

Looks good to me. Thanks @Mogztter 🙇🏼

@tancnle tancnle merged commit c39c98a into rouge-ruby:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancnle tancnle tancnle left review comments

Assignees
No one assigned
Labels
author-action The PR has been reviewed but action by the author is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cypher: inline and multi-line comments are not recognized
2 participants
@ggrossetie @tancnle