Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1760 #1762

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Conversation

vidarh
Copy link
Contributor

@vidarh vidarh commented Nov 10, 2021

No description provided.

@tancnle
Copy link
Collaborator

tancnle commented Dec 9, 2021

@jneen Something's odd with the Travis build. It blocks merging across the repo. Could you kindly look into it? 🙏🏼

@jneen
Copy link
Member

jneen commented Dec 9, 2021

I swear I've removed it like three times now

@jneen
Copy link
Member

jneen commented Dec 10, 2021

I believe I've finally purged the project of Travis CI. I've also invited you to be a maintainer @tancnle :]

@tancnle
Copy link
Collaborator

tancnle commented Dec 10, 2021

Thank you for your prompt action on this @jneen ❤️ Really appreciated.

@tancnle tancnle self-requested a review December 27, 2021 05:46
@tancnle tancnle added the needs-review The PR needs to be reviewed label Dec 27, 2021
Copy link
Collaborator

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @vidarh ❤️ The change looks good to me 👍🏼

@tancnle tancnle merged commit 75fad66 into rouge-ruby:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants