Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: fix #1871

Merged
merged 2 commits into from
Sep 9, 2022
Merged

todo: fix #1871

merged 2 commits into from
Sep 9, 2022

Conversation

dradetsky
Copy link
Contributor

As I suspected, this was incorrectly copied from e.g. the actual CoC of https://github.com/EthicalSource/contributor_covenant/ or some such place. The below is obviously suboptimal, but it at least ensures that Coraline doesn't get any more unnecessary email.

@jneen
Copy link
Member

jneen commented Sep 8, 2022

Oh thank you, that was a major oversight on my part. We can use my contact or @tancnle's instead. Sorry for the spam Coraline ><

@@ -60,7 +60,7 @@ representative at an online or offline event.

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
Copy link
Collaborator

@tancnle tancnle Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: How does this sound to you? We already have the list of maintainers in the README

Suggested change
reported to the community leaders responsible for enforcement at
reported by contacting one of the [project maintainers](https://github.com/rouge-ruby/rouge#maintainers).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more common thing is to list emails. Of the 4 maintainers listed, only 2 have emails (or indeed any contact method) listed on their profiles. It's possible that Goro has an email or other direct contact listed somewhere on his website, but due to my limited language skills I was unable to find it. In any case, the maintainers list does not even have clickable links to the profiles. To discover which ones had emails on their profiles I had to type each name in by hand. And having used github for years, I know that github.com/jneen will take me to jneen's profile (where I might possibly find an email), but not every contributor will know that. And the most important consumers of the CoC are the comparatively hesitant and unconfident n00b contributors, and I think we should not be putting lots of hoops and knowledge checks between them and making CoC reports, since it's extremely easy for us to underestimate the difficulty of these.

But I mean it's not actually worse than my version.

Actually, I don't think you should take out "responsible for enforcement" (changing "community leaders" to "project maintainers" is fine). I think identifying this responsibility, both to the reporters and those who are in fact responsible, is important. Or at least, that the decision to make this identification in the text of the CC was made advisedly, so you should only change it if you really think you understand why the decision was made. Personally, I would just change as little as possible, especially insofar as this is a PR to reduce Coraline's email backlog, so it should not be combined with copy changes to the CC anymore than other PRs should combine bug fixes and refactoring if they can avoid it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your thoughtful feedback @dradetsky 👍🏼 Really appreciated it.

since it's extremely easy for us to underestimate the difficulty of these.

Yep, totally agree with this. Sorry for the oversight.

We could perhaps reword it to read like the following:

reported to the project maintainers responsible for enforcement at jneen@jneen.net or tan.le@hey.com.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10. I laughed, I cried, I gave it 2 thumbs up.

@tancnle
Copy link
Collaborator

tancnle commented Sep 9, 2022

Thanks, @dradetsky. LGTM 👍🏼

@tancnle tancnle merged commit 90e136a into rouge-ruby:master Sep 9, 2022
@dradetsky dradetsky deleted the fix-coc-v1 branch September 10, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants