Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template strings problem in javascript lexer #1878

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Fix template strings problem in javascript lexer #1878

merged 1 commit into from
Dec 3, 2022

Conversation

DGCK81LNN
Copy link
Contributor

Backslashes should escape backslashes. Example of currently incorrectly highlighted code:

var a = "\\";
var b = '\\';
var c = `\\`;

on rouge.jneen.net

Backslashes should escape backslashes.
@tancnle
Copy link
Collaborator

tancnle commented Dec 3, 2022

Thank you for your contribution @DGCK81LNN 🙇🏼‍♂️ The PR looks good to me 👍🏼 🚀

@tancnle tancnle merged commit b503561 into rouge-ruby:master Dec 3, 2022
@DGCK81LNN DGCK81LNN deleted the patch-1 branch December 3, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants