Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of Powershell subexpressions in interpolation #1900

Merged

Conversation

tancnle
Copy link
Collaborator

@tancnle tancnle commented Dec 4, 2022

The closing bracket of the subexpression only pops out of the parameters state instead of the whole interpol state. This change ensures the closing bracket of the subexpression pops out of the interpol state.

Before After
Screenshot 2022-12-05 at 10 43 55 am Screenshot 2022-12-05 at 10 41 38 am

The closing bracket of the subexpression only pops out of the
`parameters` state instead of the whole `interpol` state. This change
ensures the closing bracket of the subexpression pops out of
the `interpol` state.
@tancnle
Copy link
Collaborator Author

tancnle commented Dec 4, 2022

👋🏼 @thecityofguanyu @retryW are any of you available to confirm if this change helps to address the reported issue? 🙏🏼

@tancnle tancnle merged commit 94696df into rouge-ruby:master Dec 12, 2022
@tancnle tancnle deleted the fix/powershell-subexpressions-interpolation branch December 12, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerShell subexpressions nested within strings
1 participant