Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: fix highlight of fully-qualified identifiers (fix #1718) #1924

Merged
merged 1 commit into from
Apr 25, 2023
Merged

php: fix highlight of fully-qualified identifiers (fix #1718) #1924

merged 1 commit into from
Apr 25, 2023

Conversation

nsfisis
Copy link
Contributor

@nsfisis nsfisis commented Jan 28, 2023

It will fix #1718.

Screenshots

Before

Screenshot from 2023-01-28 22-39-46
Screenshot from 2023-01-28 22-39-08

After

Screenshot from 2023-01-28 22-40-01
Screenshot from 2023-01-28 22-40-20

@tancnle tancnle self-requested a review February 7, 2023 22:29
@tancnle tancnle added the needs-review The PR needs to be reviewed label Feb 7, 2023
@tancnle
Copy link
Collaborator

tancnle commented Apr 25, 2023

Thanks for your contribution, @nsfisis ❤️ The change LGTM! 🚀

@tancnle tancnle added this pull request to the merge queue Apr 25, 2023
Merged via the queue into rouge-ruby:master with commit 1e2c367 Apr 25, 2023
@nsfisis nsfisis deleted the fix/1718 branch December 2, 2023 02:19
@nsfisis nsfisis mentioned this pull request Dec 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancnle tancnle Awaiting requested review from tancnle

Assignees
No one assigned
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the PHP lexer does not properly handle namespace separators in qualified names
2 participants
@nsfisis @tancnle