Fix function attributes and attribute groups on LLVM #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically move the `alignstack` keyword, before the `align` one because otherwise, the former get partially highlighted as `align` and `c`. Also add the `attributes` keyword that defines attribute groups.
Highlight attribute groups' ID as global variables as Pygments does.
pyrmont
suggested changes
Jun 18, 2019
pyrmont
added
author-action
|
Thanks for helping make Rouge a better library, @robin850! :) |
pyrmont
removed
the
maintainer-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request fixes a few problems with the LLVM lexer.
Adds missing function attribute keywords and the
attributeskeyword itself. Since some of them were already present, this script has been used to compute the difference. The list of function attributes is available here.Also, the
alignstackkeyword has been placed beforealignin the list to avoid the former being highlighted as a combination ofalignandc.Properly highlight the attribute groups' ID as global variable as Pygments does.
Before
After
The patch is split into 3 different commits to make things easy to understand but if you want me to squash them, I can do it.
Have a nice day !