Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ido faces to nano-theme based off of nano-emacs #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scottlindeman
Copy link

@scottlindeman scottlindeman commented Sep 22, 2022

Adding theme support for Ido. #36

Based off of emacs-nano

https://github.com/rougier/nano-emacs/blob/185894da71aeab33e52a1bedcde6cea4b148436c/nano-theme.el

For a diff hiding whitespace (my emacs config deletes any trailing whitespace):
https://github.com/rougier/nano-theme/pull/37/files?w=1

@rougier
Copy link
Owner

rougier commented Oct 1, 2022

Perfect (I just suggested a PR in your issue). Did you signed the copyright assignment?

@scottlindeman
Copy link
Author

Just sent out the email to the FSF. Might take a few days to get the paperwork all taken care of!

@phikal
Copy link
Contributor

phikal commented Oct 2, 2022

The copyright assignment probably isn't even necessary for this commit. More so if we disregard the unrelated whitespace changes (that ought to be part of a separate change set. @rougier have you considered adding a .dir-locals.el file to regular whitespace issues?).

@rougier
Copy link
Owner

rougier commented Oct 10, 2022

@phikal What is .dir-local.el?
@scottlindeman There are some conflicts, can you check

@phikal
Copy link
Contributor

phikal commented Oct 10, 2022

@rougier It is a file that Emacs uses to check for directory local variables. E.g. I usually have this

;;; Directory Local Variables
;;; For more information see (info "(emacs) Directory Variables")

((emacs-lisp-mode
  (show-trailing-whitespace . t)
  (indent-tabs-mode . nil)))

That way spaces are always used for indentation, and trailing whitespace is highlighted, for all Emacs users.

@rougier
Copy link
Owner

rougier commented Oct 10, 2022

Oh, good to know, thanks. Can you make a PR?

@phikal phikal mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants