Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced mail search syntax with more possibilities (without UI) #8502

Closed
jdaviescoates opened this issue Apr 13, 2022 · 7 comments
Closed

Comments

@jdaviescoates
Copy link

jdaviescoates commented Apr 13, 2022

One of the primary reasons I use Roundcube is that it supports these search operators:

from:
to:
cc:
bcc:
subject:
body:

However, like most people these days, I'm accustomed to be able to use all the search operators available in Gmail.

I particularly miss:

has:attachment
- 
in:anywhere 
is:unread
is:read
size:
larger:
smaller:
older_than:
newer_than: 
OR

in:anywhere is already possible by adjusting scope in search options, but would be nicer to be able to do it directly from the search box
older_than: and newer_than: are kinda sorta already available via the search options, but again, it'd be much nicer to be able to do it from the search box
OR was requested over at #5094

@alecpl alecpl added this to the later milestone Apr 16, 2022
@alecpl alecpl changed the title Feature request: add a load more search operators Advanced mail search syntax with more possibilities (without UI) Apr 17, 2022
@alecpl alecpl self-assigned this May 1, 2022
@alecpl alecpl modified the milestones: later, 1.7-beta May 7, 2022
@frontierpsycho
Copy link

AND would be great too, I think I'm missing that more than OR.

@alecpl
Copy link
Member

alecpl commented Jun 25, 2022

Implemented. If there's something missing or can be improved, pull requests welcome.

@alecpl alecpl closed this as completed Jun 25, 2022
@jdaviescoates
Copy link
Author

Implemented. If there's something missing or can be improved, pull requests welcome.

Wonderful, thanks!

Which ones did you implement? Just the ones mentioned in this thread, or ALL the search operators of Gmail?

Also, what version of Roundcube will these new search syntax options be available?

Thanks again!

@alecpl
Copy link
Member

alecpl commented Jun 25, 2022

It will be available in Roundcube 1.7.

@jdaviescoates
Copy link
Author

It will be available in Roundcube 1.7.

That's great, thanks!

Are you able to list which ones you've implemented?

(I'm wondering if eg in:sent etc got in there? I didn't explictly list it above, but it's one of the Gmail options)

Thanks again!

@alecpl
Copy link
Member

alecpl commented Jul 6, 2022

Look at the diff and you'll see. No, in:sent wasn't implemented, actually anything that considers folder selection is tricky regarding the UI state, so it will need more consideration to implement correctly.

@jdaviescoates
Copy link
Author

Thanks! It looks like the simplest place to see all extra bits you've added is line 124 onwards in the tests here:

tests/Actions/Mail/Search.php

You've added loads, many thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants