Config option to save drafts silently

[Jieiku]

This adds a config option to save drafts silently.

closes #8989

[github-actions]

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

[Jieiku]

it should be good to go.

[pabzm]

@Jieiku Thank you for the contribution and the instant feedback on the reminder!

@alecpl You commented in the linked issue that you would prefer to not introduce another option. I can share that feeling, but on the other hand is here a simple PR ready to merge that solves a problem for at least six people, so I would merge it.
Do you have an opinion on it? (If I don't hear from you, I'll act in two weeks.)

/remind me to act on this in two weeks

[github-actions]

@pabzm set a reminder for 12/5/2024

[alecpl]

This software is used by millions of people, so we should not merge features willy-nilly. We should not add options that do silly/trivial customisations, this probably should be even a policy. I think at this stage of the project we can decide sometimes "No, this will be a burden for the project, we don't want to support it, we can do this better".

There's always a way to do this with an external plugin.

I'd like someone to investigate this and other solutions. The solution from #8989 (comment) sounds interesting.

[pabzm]

@alecpl This is neither "silly" nor a "burden". Please be more considerate with language to not alienate contributors.

[alecpl]

You're right, this PR is in the "trivial" category. It would be silly to accept this change willy-nilly. Another person will come and say it should be a user preference, let's add it do the Preferences UI.

As for "burden", well, probably too heavy of a word, indeed, but I'm not a native English speaker, so forgive me. Every line of code, and especially every config option increases technical debt that someone has to support.

[pabzm]

I'm not a native English speaker, so forgive me

It's alright. In good old netiquette terms, let's "be conservative in what you send and liberal in what you receive", especially since most of us are not English native speakers.

Another person will come and say it should be a user preference, let's add it do the Preferences UI.

If people take the time to think of a solution, implement it, open a reasonable pull-request and gather several positive reactions, I think we should accept that, too.

Every line of code, and especially every config option increases technical debt that someone has to support.

That ist true in general, but to be honest: if you bring that argument against such a small and simple PR it very much conveys that you want Roundcubemail to not change. From my point of view that behaviour will make Roundube die, not connecting with a lively community and embracing change.

[alecpl]

That is true in general, but to be honest: if you bring that argument against such a small and simple PR it very much conveys that you want Roundcubemail to not change.

I think many other accepted PRs prove otherwise, including huge code quality changes. Stop with this BS. If you expect an established project to become "let's try this" playground then indeed we have a problem.

[pabzm]

@Jieiku Sorry this is happening in your PR. We'll sort this out elsewehere and come back to you later.

[github-actions]

👋 @pabzm, act on this