#43: Fix server streaming #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treams (pub-sub pattern) that checks client abandons
…e kotlin channel when sending message to a client has failed
… of artifact) of grpc-kotlin-gen
… client unary calls: extend chat.proto, add clientSS, fix README
|
Thanks for doing this. There's a minor conflict with changes done in master, if you just fix that, I'll merge this tomorrow. |
igor-kovalchuk
force-pushed
the
fix_server_streaming_43
branch
from
5bb1f04
to
8c863ea
Compare
|
Fixed, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-streaming: Close kotlin/coroutines channel on client abandon; including dirty shutdowns (network failures or client process crash).
This fixes memory exhaust, subscribers registry bloating on the server.