[pgadmin4] secret-server-definitions not respecting existingSecret

[dawidmalina]

Describe the bug
With latest version (1.17.0) existingSecret is not respected! We can have only provided configuration provided as ConfigMap or Secret and secret name is hard coded to the one that is always created {{ $fullName }}-server-definitions.

Which chart:
1.17.0

What you expected to happen:
I am able to define different resourceType, ex ExistingSecret or simply existingSecret property is properly handled.

How to reproduce it (as minimally and precisely as possible):

Use following values:

  existingSecret: pgadmin-secrets
  serverDefinitions:
    enabled: true

Anything else we need to know:

[rowanruseler]

ah I see, the new secrets for server-definitions does not have the exclusion of existingSecret. I'll create a PR!

[rowanruseler]

@dawidmalina just merged it, so 1.17.1 should contain the fix. If this is not what you meant, please let me know.

[dawidmalina]

Hi, thanks for the quick reply. It's almost ok. The only missing point here is to consume name of the secret defines with existingSecret instead of hardcoded values: https://github.com/rowanruseler/helm-charts/blob/master/charts/pgadmin4/templates/deployment.yaml#L217

[rowanruseler]

Feel free to open a pull request if you see a better method of having multiple secrets and the possibility to have the server definitions also as a config map. Apologies for the late response, I was away for a week.