Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't wait stale timeout #5

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

knopki
Copy link
Contributor

@knopki knopki commented Oct 1, 2020

Clear event timeout if event already fired. This saves big amount of time in spank after all work is already done.

TImeout is set to 10000. Before:

time spank
✔ Found matching config: Routify 2
✔ found user config: spank.config.js
✔ Inline dynamic imports
✔ Exported 7 pages in 916 ms
4.61user 0.14system 0:12.89elapsed 36%CPU (0avgtext+0avgdata 206348maxresident)k
0inputs+784outputs (0major+54695minor)pagefaults 0swaps

After:

time spank
✔ Found matching config: Routify 2
✔ found user config: spank.config.js
✔ Inline dynamic imports
✔ Exported 7 pages in 890 ms
4.34user 0.14system 0:02.90elapsed 154%CPU (0avgtext+0avgdata 205408maxresident)k
0inputs+784outputs (0major+56510minor)pagefaults 0swaps

10 seconds faster.

@jakobrosenberg
Copy link
Member

Thanks @knopki. Great catch!

@jakobrosenberg jakobrosenberg merged commit f79c3e6 into roxiness:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants