Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable preview of CustomControl's template #12

Closed
roxk opened this issue Apr 14, 2024 · 2 comments
Closed

Enable preview of CustomControl's template #12

roxk opened this issue Apr 14, 2024 · 2 comments

Comments

@roxk
Copy link
Owner

roxk commented Apr 14, 2024

No description provided.

@roxk
Copy link
Owner Author

roxk commented Apr 17, 2024

Blocker: Dictionary containing control template can't be parsed by xaml reader it seems. Bummer. But there should be way around that.

@roxk
Copy link
Owner Author

roxk commented Apr 17, 2024

Good news: there was bugs in the XAML trimmer that doesn't preserve namespaces declared at root. This caused TargetType="loca;Foo" to fail to resolve local:Foo since local was removed. Fixing it allowed TargetType to be present in style, and the resource dictionary could be loaded.

There is still the edge case where the namespace is defined in parent scope, but this is very rare in the grand scheme of things and can be fixed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant