Fix bug for long sequences (> 640) #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed template code: - Only one value for the template is used (T=int64_t) - In cython it is easier to use non-template code - Fix warning: comparison of integer expressions of different signedness -
|
This bug was introduced in #39 |
thequilo
added a commit
to fgnt/meeteval
that referenced
this pull request
Jun 21, 2023
editdistance produces wrong results for long sequences (roy-ht/editdistance#103) and the maintainer doesn't seem to be active. Use our impelmentation of the Levenshtein distance instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this package to compute the so called concatenated minimum permutation word error rate.
While this package is faster than kaldialign, kaldialign computes the individual ins/del/sub.
I compared the distance values for long texts (several thousand words) and they were not the same.
It turned out, that this package uses another implementation (
edit_distance_dp), when the number of words is larger than 640.In the code of
edit_distance_dpis a bug, the first value in the vector is not initialized.This PR contains a fix for the bug and adds tests for
edit_distance_dp.I had to expose
edit_distance_dpto write a test.