Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add python 3.10 wheels #88

Merged
merged 5 commits into from
Oct 30, 2022
Merged

✨ Add python 3.10 wheels #88

merged 5 commits into from
Oct 30, 2022

Conversation

s-weigand
Copy link
Contributor

Update github action in CI workflow and add python 3.10 wheels.

Building wheels for python 3.11 does not work yet, but joerick/cibuildwheel will upgrade their python 3.11 version from rc2 to the proper release from 2days ago in the next release. Might also be a Cython configuration issue since the error is why compilation.

editdistance/bycython.cpp:216:12: fatal error: longintrepr.h: No such file or directory
          216 |   #include "longintrepr.h"
List of created wheels 
-rw-r--r-- 1 runner docker 27537[8](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:9) Oct 26 15:04 editdistance-0.6.0-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker 280594 Oct 26 14:49 editdistance-0.6.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker 278364 Oct 26 14:52 editdistance-0.6.0-cp310-cp310-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker 77[9](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:10)[10](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:11)1 Oct 26 15:29 editdistance-0.6.0-cp310-cp310-musllinux_1_1_aarch64.whl
-rw-r--r-- 1 runner docker 843734 Oct 26 15:18 editdistance-0.6.0-cp310-cp310-musllinux_1_1_i686.whl
-rw-r--r-- 1 runner docker 791503 Oct 26 15:16 editdistance-0.6.0-cp310-cp310-musllinux_1_1_x86_64.whl
-rw-r--r-- 1 runner docker 273931 Oct 26 14:55 editdistance-0.6.0-cp36-cp36m-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker 278757 Oct 26 14:48 editdistance-0.6.0-cp36-cp36m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker 276585 Oct 26 14:51 editdistance-0.6.0-cp36-cp36m-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker 777224 Oct 26 15:19 editdistance-0.6.0-cp36-cp36m-musllinux_1_1_aarch64.whl
-rw-r--r-- 1 runner docker 841863 Oct 26 15:16 editdistance-0.6.0-cp36-cp36m-musllinux_1_1_i686.whl
-rw-r--r-- 1 runner docker 789676 Oct 26 15:15 editdistance-0.6.0-cp36-cp36m-musllinux_1_1_x86_64.whl
-rw-r--r-- 1 runner docker 275128 Oct 26 14:57 editdistance-0.6.0-cp37-cp37m-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker 280207 Oct 26 14:49 editdistance-0.6.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker 278025 Oct 26 14:51 editdistance-0.6.0-cp37-cp37m-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker 778457 Oct 26 15:21 editdistance-0.6.0-cp37-cp37m-musllinux_1_1_aarch64.whl
-rw-r--r-- 1 runner docker 843178 Oct 26 15:17 editdistance-0.6.0-cp37-cp37m-musllinux_1_1_i686.whl
-rw-r--r-- 1 runner docker 790786 Oct 26 15:15 editdistance-0.6.0-cp37-cp37m-musllinux_1_1_x86_64.whl
-rw-r--r-- 1 runner docker 275707 Oct 26 14:59 editdistance-0.6.0-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker 280774 Oct 26 14:49 editdistance-0.6.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker 278469 Oct 26 14:51 editdistance-0.6.0-cp38-cp38-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker 779235 Oct 26 15:24 editdistance-0.6.0-cp38-cp38-musllinux_1_1_aarch64.whl
-rw-r--r-- 1 runner docker 843740 Oct 26 15:17 editdistance-0.6.0-cp38-cp38-musllinux_1_1_i686.whl
-rw-r--r-- 1 runner docker 791538 Oct 26 15:15 editdistance-0.6.0-cp38-cp38-musllinux_1_1_x86_64.whl
-rw-r--r-- 1 runner docker 275212 Oct 26 15:01 editdistance-0.6.0-cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker 280363 Oct 26 14:49 editdistance-0.6.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker 278157 Oct 26 14:52 editdistance-0.6.0-cp39-cp39-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker 778876 Oct 26 15:26 editdistance-0.6.0-cp39-cp39-musllinux_1_1_aarch64.whl
-rw-r--r-- 1 runner docker 843513 Oct 26 15:17 editdistance-0.6.0-cp39-cp39-musllinux_1_1_i686.whl
-rw-r--r-- 1 runner docker 791285 Oct 26 15:16 editdistance-0.6.0-cp39-cp39-musllinux_1_1_x86_64.whl
-rw-r--r-- 1 runner docker  25571 Oct 26 15:07 editdistance-0.6.0-pp37-pypy37_pp73-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker  29126 Oct 26 14:52 editdistance-0.6.0-pp37-pypy37_pp73-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker  25228 Oct 26 14:50 editdistance-0.6.0-pp37-pypy37_pp73-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker  25208 Oct 26 15:10 editdistance-0.6.0-pp38-pypy38_pp73-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker  28790 Oct 26 14:53 editdistance-0.6.0-pp38-pypy38_pp73-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
-rw-r--r-- 1 runner docker  24682 Oct 26 14:50 editdistance-0.6.0-pp38-pypy38_pp73-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker  252[11](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:12) Oct 26 15:[13](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:14) editdistance-0.6.0-pp39-pypy39_pp73-manylinux_2_17_aarch64.manylinux20[14](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:15)_aarch64.whl
-rw-r--r-- 1 runner docker  28844 Oct 26 14:53 editdistance-0.6.0-pp39-pypy39_pp73-manylinux_2_5_i686.manylinux1_i686.manylinux_2_[17](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:18)_i686.manylinux[20](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:21)14_i686.whl
-rw-r--r-- 1 runner docker  [24](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:25)698 Oct [26](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:27) 14:50 editdistance-0.6.0-pp[39](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036547#step:5:40)-pypy39_pp73-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runneradmin 197121 245[8](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036825#step:5:9)3 Oct 26 14:56 editdistance-0.6.0-cp310-cp310-win32.whl
-rw-r--r-- 1 runneradmin 197121 22290 Oct 26 14:57 editdistance-0.6.0-cp310-cp310-win_amd64.whl
-rw-r--r-- 1 runneradmin 1[9](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036825#step:5:10)7121 25546 Oct 26 14:49 editdistance-0.6.0-cp36-cp36m-win32.whl
-rw-r--r-- 1 runneradmin 197121 23698 Oct 26 14:50 editdistance-0.6.0-cp36-cp36m-win_amd64.whl
-rw-r--r-- 1 runneradmin 197121 24467 Oct 26 14:51 editdistance-0.6.0-cp37-cp37m-win32.whl
-rw-r--r-- 1 runneradmin 197121 22229 Oct 26 14:52 editdistance-0.6.0-cp37-cp37m-win_amd64.whl
-rw-r--r-- 1 runneradmin 197121 24534 Oct 26 14:52 editdistance-0.6.0-cp38-cp38-win32.whl
-rw-r--r-- 1 runneradmin 197121 22259 Oct 26 14:53 editdistance-0.6.0-cp38-cp38-win_amd64.whl
-rw-r--r-- 1 runneradmin 197121 24577 Oct 26 14:54 editdistance-0.6.0-cp39-cp39-win32.whl
-rw-r--r-- 1 runneradmin 197121 22288 Oct 26 14:55 editdistance-0.6.0-cp39-cp39-win_amd64.whl
-rw-r--r-- 1 runneradmin 197121 2[10](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036825#step:5:11)62 Oct 26 14:58 editdistance-0.6.0-pp37-pypy37_pp73-win_amd64.whl
-rw-r--r-- 1 runneradmin 197[12](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036825#step:5:13)1 21061 Oct 26 [14](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036825#step:5:15):59 editdistance-0.6.0-pp38-pypy38_pp73-win_amd64.whl
-rw-r--r-- 1 runneradmin 197121 21084 Oct 26 [15](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508036825#step:5:16):00 editdistance-0.6.0-pp39-pypy39_pp73-win_amd64.whl
-rw-r--r--   1 runner  staff  36409 Oct 26 15:0[8](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508037001#step:5:9) editdistance-0.6.0-cp310-cp310-macosx_10_9_universal2.whl
-rw-r--r--   1 runner  staff  20949 Oct 26 15:07 editdistance-0.6.0-cp310-cp310-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  1[9](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508037001#step:5:10)886 Oct 26 15:08 editdistance-0.6.0-cp3[10](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508037001#step:5:11)-cp310-macosx_11_0_arm64.whl
-rw-r--r--   1 runner  staff  20855 Oct 26 14:49 editdistance-0.6.0-cp36-cp36m-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  20878 Oct 26 14:54 editdistance-0.6.0-cp37-cp37m-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  36386 Oct 26 14:58 editdistance-0.6.0-cp38-cp38-macosx_10_9_universal2.whl
-rw-r--r--   1 runner  staff  20937 Oct 26 14:56 editdistance-0.6.0-cp38-cp38-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  19876 Oct 26 14:57 editdistance-0.6.0-cp38-cp38-macosx_[11](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508037001#step:5:12)_0_arm64.whl
-rw-r--r--   1 runner  staff  36398 Oct 26 15:02 editdistance-0.6.0-cp39-cp39-macosx_10_9_universal2.whl
-rw-r--r--   1 runner  staff  20939 Oct 26 14:59 editdistance-0.6.0-cp39-cp39-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  19881 Oct 26 15:01 editdistance-0.6.0-cp39-cp39-macosx_11_0_arm64.whl
-rw-r--r--   1 runner  staff  18363 Oct 26 15:09 editdistance-0.6.0-pp37-pypy37_pp73-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  18347 Oct 26 15:11 editdistance-0.6.0-pp38-pypy38_pp73-macosx_10_9_x86_64.whl
-rw-r--r--   1 runner  staff  18348 Oct 26 15:[13](https://github.com/s-weigand/editdistance/actions/runs/3330050694/jobs/5508037001#step:5:14) editdistance-0.6.0-pp39-pypy39_pp73-macosx_10_9_x86_64.whl

closes #64
closes #71
closes #72
closes #76
closes #85
closes #86
closes #87

@s-weigand
🚇⬆️ Upgrade cibuildwheel action
63ec8cc
@s-weigand
🧪👌 Changed test runner from nose to pytest
12e4cae
@s-weigand
🚇🩹 Skip py311 build since it is using rc2 version and build fails
d3160c6 
The build error is:

editdistance/bycython.cpp:216:12: fatal error: longintrepr.h: No such file or directory
          216 |   #include "longintrepr.h"
@s-weigand
🚧 Raised min python version to 3.6 and added python 3.10 classifier
d2204c3 
Python 3.5 is EOL for over 2 years and not supported by cibuildwheel (at least not a recent version)
@s-weigand
🚇⬆️ Upgrade other Github actions to new version
6730037
roy-ht
roy-ht approved these changes Oct 26, 2022
View reviewed changes
Copy link
Owner

@roy-ht roy-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your lot of work!!

@roy-ht
Copy link
Owner

roy-ht commented Oct 26, 2022

I'll merge and create next release in a few days.

@Joshix-1
Copy link
Contributor

Joshix-1 commented Oct 27, 2022 •
edited
Loading

the problem with 3.11 ist the editdistance/bycython.cpp that needs to be generated again, then it works

@roy-ht roy-ht merged commit c152086 into roy-ht:master Oct 30, 2022
@roy-ht roy-ht mentioned this pull request Oct 30, 2022
Merged
@s-weigand s-weigand deleted the py310-fix branch October 30, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roy-ht roy-ht roy-ht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wheels of editdistance for 3.10
3 participants
@s-weigand @roy-ht @Joshix-1