Skip to content

Commit

Permalink
Do not manipulate strings in the args of an assert
Browse files Browse the repository at this point in the history
Summary:
We should not be doing any work to handle an assertion. While we could, in theory, create a templatized assertion capability, in practice, it's unlikely that this stringified mainAxisOwnerSize is going to tell us much.

## Changelog

[Internal]

Reviewed By: jorge-cab

Differential Revision: D65862761
  • Loading branch information
rozele authored and facebook-github-bot committed Nov 13, 2024
1 parent d3c5446 commit b053c1b
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -696,9 +696,7 @@ static float distributeFreeSpaceSecondPass(
yoga::assertFatalWithNode(
currentLineChild,
yoga::isDefined(updatedMainSize),
("updatedMainSize is undefined. mainAxisOwnerSize: " +
std::to_string(mainAxisOwnerSize))
.c_str());
"updatedMainSize is undefined.");

deltaFreeSpace += updatedMainSize - childFlexBasis;

Expand Down

0 comments on commit b053c1b

Please sign in to comment.