Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementations of embedded_io::Write for UartPeripheral #895

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix implementations of embedded_io::Write for UartPeripheral #895

merged 2 commits into from
Feb 4, 2025

Conversation

jannic
Copy link
Member

@jannic jannic commented Feb 4, 2025

Fixes #840

@jannic jannic mentioned this pull request Feb 4, 2025
Closed
2 tasks
thejpster
thejpster approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically correct, but some comments might help the next person who looks at this :)

@jannic jannic merged commit eea9ecf into rp-rs:main Feb 4, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejpster thejpster thejpster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our implementation of embedded_io::Write is wrong
2 participants
@jannic @thejpster