V2 - React Router v7

[rphlmr]

V2 Release for React Router 7

Description

This is a "soft" breaking change: @remix-run dependency becomes react-router.

No API changes.

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/rphlmr/react-router-hono-server@18

commit: b9caf4c

[rphlmr]

waiting for sergiodxa/remix-hono#297

[firxworx]

Hi @rphlmr thank-you for react-router-hono-server! It answered some questions I had. I have worked with react-router a ton of times on SPA's but not much with remix. Earlier today I upgraded an SPA to React Router v7 today with all future flags enabled and it was painless so I figured it was a good time to learn a little more about the feasibility to use v7 in a new full stack project.

Suggestion to unblock and improve maintainability

I thought I'd share a first thought I had when I reviewed the code in this package and remix-hono, before I even looked at the issues and saw this one:

"if react-router-hono-server is only using remix-hono/handler, and that's only a handful of lines of code, why wouldn't the author directly incorporate those crucial lines directly in react-router-hono-server?

Reference: https://github.com/sergiodxa/remix-hono/blob/main/src/handler.ts

I think adding yet another set of third-party dependencies, maintainers, etc. adds unnecessary risks for what amount to a few lines of code, especially where those lines are so critical for this package to succeed in its purpose. I think that this early PR being blocked is an early warning about future challenges to come.

The collection of exports in remix-hono while insightful are all very succinct and ripe to copy as needed.

By all means I agree to give credit where credit is due for remix-hono and sergiodxa in the README, along with mention of some of the other exports that might potentially be useful to some :) Thanks again for creating this repo :)

[rphlmr]

Thank @firxworx!
You are right, it could be simpler to fork this part since it is really a basic binding and the core part of this library.
I'm also a maintainer of remix-hono and I started to re-export it. Then I realized that it would be better to compound them instead of mixing them, so I rolled back.

Let's do this, of course, with credits.

[rphlmr]

Okay, there is an issue with the virtual module. It seems it only works for local code and not a library. Node resolves it before Vite or something like that.
I will try later on monday and or rollback some lines

[rphlmr]

Okay, let's try a new approach: a Vite plugin!