Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{pre,post}-transaction-actions: fix package files filtering regression #540

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kszczek
Copy link

@kszczek kszczek commented Jun 12, 2024

According to DNF User's FAQ, starting with Fedora 40 filelists metadata became optional. This caused a regression in pre and post transaction actions plugins which rely on this information. Let's request filelists metadata whenever the pre or post transaction actions plugin is enabled.

According to DNF User's FAQ, starting with Fedora 40 filelists metadata
became optional. This caused a regression in pre and post transaction
actions plugins which rely on this information. Let's request filelists
metadata whenever the pre or post transaction actions plugin is enabled
and at least one action line contains a file pattern.

= changelog =
msg: Fix package files filtering in pre and post-transaction-actions plugins
type: bugfix
@kszczek kszczek force-pushed the pre-post-transaction-actions-fix branch from 658e16d to 9e893bb Compare June 13, 2024 08:24
@kszczek
Copy link
Author

kszczek commented Jun 13, 2024

Force-pushed to make this patch more robust. Instead of requesting filelists metadata whenever the plugin is enabled, it now also checks if at least one action line contains a file pattern before requesting filelists.

@kszczek
Copy link
Author

kszczek commented Jun 13, 2024

To work around this issue in the meantime, just set optional_metadata_types=filelists under the [main] section in /etc/dnf/dnf.conf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant