base: Add obsoleters of only latest versions #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: As a part of the PR there is a commit containing translations. Is it intended? |
j-mracek
reviewed
Sep 21, 2023
dnf/base.py
Outdated
| @@ -1690,7 +1690,13 @@ def trans_install(query, remove_query, comps_pkg, strict): | |||
| sltr.set(provides="({} if {})".format(comps_pkg.name, comps_pkg.requires)) | |||
| else: | |||
| if self.conf.obsoletes: | |||
| query = query.union(self.sack.query().filterm(obsoletes=query)) | |||
| # if there are no installed packages in the query, add only | |||
| # obsoleters of the latest versions. | |||
There was a problem hiding this comment.
May I ask you to add information why we should add all obsoletes when installed package is in the selection. It might be worth to document it.
|
The implementation looks good to me |
|
@m-blaha All tests passed, the merge is only blocked by update of a note in the code and removal of a commit with translation (rebase might help). |
m-blaha
force-pushed
the
mblaha/obsolete-latest
branch
from
8b39a0e to
337b30d
Compare
Resolves situations where a package is in older version obsoleted, but there is newer (not obsoleted) version available. This patch covers installation of group packages and arch specific packages. The rest is in hawkey library. Relevant bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2183279 https://bugzilla.redhat.com/show_bug.cgi?id=2176263
m-blaha
force-pushed
the
mblaha/obsolete-latest
branch
from
337b30d to
c9411de
Compare
|
LGTM, tested locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves situations where a package is in older version obsoleted, but
there is newer (not obsoleted) version available. This patch covers
installation of group packages and arch specific packages. The rest is in
hawkey library.
Relevant bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2183279
https://bugzilla.redhat.com/show_bug.cgi?id=2176263
See also: rpm-software-management/libdnf#1624 for
libdnf part of the fix.