Move return value check right after parser call for fromxml_str()
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Aug 22, 2023
| if (parsed_ret == -1) { | ||
| PyErr_SetString(PyCOMPSExc_ParserError, "Fatal parser error"); | ||
| return NULL; | ||
| } |
There was a problem hiding this comment.
Are you sure that the movement will not create memory leak? There are several object de-alocated after the return.
There was a problem hiding this comment.
options value could be the first candidate.
There was a problem hiding this comment.
Oh right, in case of an error it was causing a memory leak.
I have updated it, please take a look.
It is not sufficient to check the return value after the function output is used. We need check it sooner to avoid a Segmentation fault. For: rpm-software-management#103
Remove output checks after the parsing raises and exception. It also adds one more test with completely invalid xml input.
jan-kolarik
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #103