Improve performance for module query

It improve performance when both name and stream is empty.
rpm-software-management · Mar 11, 2021 · 38942d4 · 38942d4
1 parent 943d9a1
commit 38942d4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/libdnf/module/ModulePackageContainer.cpp b/libdnf/module/ModulePackageContainer.cpp
@@ -775,9 +775,11 @@ ModulePackageContainer::query(std::string name, std::string stream, std::string
     Query query(pImpl->moduleSack, Query::ExcludeFlags::IGNORE_EXCLUDES);
     // platform modules are installed and not in modules std::Map.
     query.available();
-    std::ostringstream ss;
-    ss << stringFormater(name) << ":" << stringFormater(stream);
-    query.addFilter(HY_PKG_DESCRIPTION, HY_GLOB, ss.str().c_str());
+    if (!name.empty() || !stream.empty()) {
+        std::ostringstream ss;
+        ss << stringFormater(name) << ":" << stringFormater(stream);
+        query.addFilter(HY_PKG_DESCRIPTION, HY_GLOB, ss.str().c_str());
+    }
     if (!context.empty()) {
         query.addFilter(HY_PKG_SUMMARY, HY_GLOB, context.c_str());
     }