Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf history rollback cmd causes core dump #1652

Closed
chenhaixing123 opened this issue Apr 17, 2024 · 1 comment · Fixed by #1658
Closed

dnf history rollback cmd causes core dump #1652

chenhaixing123 opened this issue Apr 17, 2024 · 1 comment · Fixed by #1658
Assignees
@jan-kolarik
Labels
Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@chenhaixing123
Copy link

chenhaixing123 commented Apr 17, 2024 •
edited

dnf history rollback cmd causes codedump

here are the steps to reproduce the issue
1.dnf remove -y samba samba-common
2.dnf install -y samba samba-common
3.dnf history rollback -y 1

expected result：
no core dumped

actual results：
Aborted (core dumped)

related:#1644

GDB information：

libdnf/libdnf/transaction/MergedTransaction.cpp

Line 289 in 85432df

itemPairMap.erase(getItemIdentifier(firstItem));

libdnf/libdnf/transaction/MergedTransaction.cpp

Line 316 in 85432df

resolveRPMDifference(itemPairMap, previousItemPair, mTransItem);

libdnf/libdnf/transaction/MergedTransaction.cpp

Line 418 in 85432df

resolveErase(itemPairMap, previousItemPair, mTransItem);

@jan-kolarik jan-kolarik self-assigned this Apr 23, 2024
@jan-kolarik jan-kolarik changed the title dnf history rollback cmd causes codedump dnf history rollback cmd causes core dump Apr 23, 2024
@jan-kolarik jan-kolarik added the Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take label Apr 23, 2024
@jan-kolarik jan-kolarik mentioned this issue Apr 23, 2024
Merged
@jan-kolarik
Copy link
Member

Thanks for the report. I've replicated the described behavior and prepared the fix.

@jan-kolarik jan-kolarik mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-kolarik jan-kolarik

Labels
Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MergedTransaction: Fix invalid memory access when dropping items rpm-software-management/libdnf
2 participants
@chenhaixing123 @jan-kolarik