MergedTransaction: Calculate RPM difference between two same versions as no-op #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as no-op Upstream commit: 54823d8 If a package of a particular version is installed and would still be installed after a list of transactions, it's more user friendly to treat the whole situation as "do nothing". Resolves: https://issues.redhat.com/browse/RHEL-17494
|
LGTM, though an issue was discovered related to this patch, so I'd recommend not backporting it without the additional fix. |
|
I see. Then I will wait on that a for #1652 and then add it into this pull request. |
|
That is #1658. |
Upstream commit: 90d2ffa When an item is dropped from the merged transaction, the `ItemPair` reference becomes invalid and should no longer be used. Resolves: https://issues.redhat.com/browse/RHEL-17494
|
I added a fix from #1652. |
jan-kolarik
merged commit 020aab8
into
rpm-software-management:rhel-9.5
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit: 54823d8
Upstream commit: 90d2ffa
Resolves: https://issues.redhat.com/browse/RHEL-17494
Tests: rpm-software-management/ci-dnf-stack#1490
@jan-kolarik, could you please review this backport of your commit into rhel-9.5 branch?